Code

Support for cgroupsv2#791

Code

Merged

PhilippWendler merged 153 commits intomainsosy-lab/benchexec:mainfrom cgroupsv2sosy-lab/benchexec:cgroupsv2Copy head branch name to clipboardOct 20, 2023

+1,916-765

Commits

Commits on Oct 14, 2021

• [WIP] cgroups: implement cgroupsv2 support

  Show description for 434679d
  globin

  committed
  434679d

• [WIP] cgroups: default to cgroups v2 code temporarily

  Show description for 6251cbe
  globin

  committed
  6251cbe

• cgroups: remove debug logging

  globin

  committed
  c6155a1

• cgroups: try with user service

  globin

  committed
  5b23179

• cgroups: fix paths

  globin

  committed
  66c22cd

• cgroups: remove cgrulesd code in v2

  globin

  committed
  9c6e3ff

• cgroups: WIP abstraction for v1 & v2

  globin

  committed
  133d5bf

• cgroups: fix permission hints

  globin

  committed
  3182bca

• cgroups: WIP cleanup & fixes

  globin

  committed
  b4fe3dc

• cgroups: cleanup some path handling

  globin

  committed
  c33516c

• cgroups: fix issues from refactoring

  globin

  committed
  5f108ef

• cgroups: add cgroupsv2 bootstrap service

  globin

  committed
  c313298

• cgroups: parameterise cgv2 fallback path

  globin

  committed
  a67214b

• cgroups: OOM handling

  globin

  committed
  1d0e1c0

• cgroups: remove unreferenced code

  globin

  committed
  e41913e

• cgroups: cgroup.kill handling for >=5.14

  globin

  committed
  2307834

• cgroups: WIP IO and v2 CPU

  globin

  committed
  4a354a9

• cgroups: type-checking clean-up

  globin

  committed
  1215096

• cgroups: CI flake fixes?

  globin

  committed
  89c5d64

• cgroups: v2 CPU subsystem

  Show description for f121081
  globin

  committed
  f121081

• cgroups: cleanup and available mem node fix

  globin

  committed
  6b1f75a

• cgroups: initial v2 IO implementation

  Show description for 34d2c8f
  globin

  committed
  34d2c8f

• cgroups: fix v2 cgroup removal assertion

  globin

  committed
  3206095

• cgroups: update default branch name in links

  globin

  committed
  f92fea5

• cgroups: fix percpu usage output

  globin

  committed
  26ab65a

• cgroups: fix resource handling

  globin

  committed
  4a4eacd

Commits on Oct 20, 2021

• cgroups: implement oom/memlimit handling

  globin

  committed
  aa0b905

• cgroups: CI fixes

  globin

  committed
  1245dc0

Commits on Oct 28, 2021

• cgroups: implement non-fallback code path for v2

  Show description for c815670
  globin

  committed
  c815670

• Merge remote-tracking branch 'origin/main' into cgroupsv2

  globin

  committed
  9dd3282

• Merge remote-tracking branch 'origin/main' into cgroupsv2

  globin

  committed
  78b39b0

Commits on Nov 2, 2021

• cgroups: fix file/path handling edge cases

  globin

  committed
  db9e6c0

Commits on Nov 24, 2021

• Merge remote-tracking branch 'origin/main' into cgroupsv2

  globin

  committed
  f9481ed

Commits on Nov 25, 2021

• cgroups: use pystemd with cgroupsv2

  Show description for ffd05e5
  globin

  committed
  ffd05e5

Commits on Dec 2, 2021

• cgroups: only allow execution in proper cgroup

  Show description for bab92a5
  globin

  committed
  bab92a5

Commits on Dec 4, 2021

• cgroups: add some->total pressure metrics for cgroups v2

  Show description for 8ea6777
  globin

  committed
  8ea6777

• cgroups: partially revert cgroup-availability checking

  Show description for 3469607
  globin

  committed
  3469607

• cgroups: cleanup

  globin

  committed
  5db0ec8

Commits on Jan 9, 2022

• Merge remote-tracking branch 'origin/main' into cgroupsv2

  globin

  committed
  f7b369c

Commits on Jan 11, 2022

• move benchexec's process group to scope not runexec

  globin

  committed
  5b4f309

• add pressure metrics to test whitelist

  globin

  committed
  21fdde2

• Merge remote-tracking branch 'origin/main' into cgroupsv2

  globin

  committed
  a5a8a00

• cgroups v2: remove fallback logic

  globin

  committed
  c3d7c1c

Commits on Jan 12, 2022

• util.get_pgrp_pids: fix race condition

  Show description for 4d32b32
  globin

  committed
  4d32b32

• benchmark-cgroup2.service: remove

  Show description for 9728457
  globin

  committed
  9728457

Commits on Feb 26, 2022

• Merge remote-tracking branch 'origin/main' into cgroupsv2

  globin

  committed
  11d874a

Commits on Feb 27, 2022

• tests: do not skip if executable is on PATH

  Show description for b9d2c63
  globin

  committed
  b9d2c63

• tests: fix cgroup v2 tests

  globin

  committed
  567480b

• tests: reformat

  globin

  committed
  2212ff6

• gitlab-ci: install pystemd

  globin

  committed
  4eec9e0

• gitlab-ci: actually install pystemd

  globin

  committed
  6341f71

Commits on Feb 28, 2022

• gitlab-ci: install libsystemd and python headers instead

  globin

  committed
  ab65a52

• tests: fix typo

  globin

  committed
  3576599

• gitlab-ci: fix pytype

  globin

  committed
  758ceec

• gitlab-ci: really fix pytype?

  globin

  committed
  d1691bd

• gitlab-ci: really fix pytype?!

  globin

  committed
  2a34e76

Commits on Mar 7, 2022

• cgroups: make sure paths are strings before escaping

  globin

  committed
  f4c3f0e

• check_cgroups: fix for cgv2

  globin

  committed
  daad5e4

• test_runexecutor: use existing metric for cgv2

  globin

  committed
  3e27f1d

• util.get_prgp_pids: fix when binaries with spaces are running

  globin

  committed
  d70a66b

• util.get_prgp_pids: fix typo

  globin

  committed
  a6bf3d2

• util.get_prgp_pids: rerun black

  globin

  committed
  c42b142

• Merge remote-tracking branch 'origin/main' into cgroupsv2

  globin

  committed
  7386ec2

• test_runexecutor: fix typo

  globin

  committed
  3b776d5

Commits on Jul 22, 2022

• Merge branch 'main' into cgroupsv2

  PhilippWendler

  committed
  0ae1aad

• Port a921d6b to this branch

  Show description for 4f4aff8
  PhilippWendler

  committed
  4f4aff8

Commits on Sep 15, 2022

• Revert change to test parameter that does not belong to cgroupsv2 branch

  PhilippWendler

  committed
  568c614

• Simplify creation of random token and silence flake8 warning

  Show description for 3f3bcd0
  PhilippWendler

  committed
  3f3bcd0

• Fix containerexec: it should not use cgroups

  PhilippWendler

  committed
  28a2aa3

• Fix bug in cgroups handling: has_tasks() always returned False

  Show description for 3829226
  PhilippWendler

  committed
  3829226

• Fix handling of child cgroups

  Show description for ffe3913
  PhilippWendler

  committed
  ffe3913

• Add method from Cgroups classes also to abstract base class

  PhilippWendler

  committed
  9cc8deb

• Remove special casing for cgroup versions from RunExecutor

  Show description for 885e12c
  PhilippWendler

  committed
  885e12c

• Make some methods on CgroupsV2 easier to use

  Show description for 86ff57b
  PhilippWendler

  committed
  86ff57b

• Rewrite main logic for initializing cgroups

  Show description for 9729ef5
  PhilippWendler

  committed
  9729ef5

• Make check_cgroups work properly for cgroups v2

  Show description for a2eabf1
  PhilippWendler

  committed
  a2eabf1

• Refactoring: Move fields and methods from instance to class for Cgroups

  Show description for da642c9
  PhilippWendler

  committed
  da642c9

• Refactoring: simplify creation of Cgroups instances

  Show description for 3e47e4b
  PhilippWendler

  committed
  3e47e4b

• Remove restriction to well-known controllers for cgroups v2

  Show description for 873759c
  PhilippWendler

  committed
  873759c

• Refactor CgroupsV2.create_fresh_child_cgroup()

  Show description for 84535f8
  PhilippWendler

  committed
  84535f8

• Do not throw BenchExecException from cgroups module

  Show description for ddf5ad0
  PhilippWendler

  committed
  ddf5ad0

• More robust parsing of io.stat on cgroups v2

  Show description for dc8adf0
  PhilippWendler

  committed
  dc8adf0

• Fix output of pressure stall time with cgroups v2

  Show description for f350ed6
  PhilippWendler

  committed
  f350ed6

• First step at better error handling for cgroups v2

  Show description for 9fcf85c
  PhilippWendler

  committed
  9fcf85c

• Merge commit '5f48889dfa52d5ac130bdd38e4d9c8ff6940cbfb' into cgroupsv2

  PhilippWendler

  committed
  38fe93b

• format

  PhilippWendler

  committed
  5d44299

Commits on Feb 27, 2023

• Copy over protection for #840 to cgroupsv2 branch

  Show description for c4e447c
  PhilippWendler

  committed
  c4e447c

• Merge commit 'b3462dc69049a863c1309b39fb65883eba335c33' into cgroupsv2

  Show description for d150d47
  PhilippWendler

  committed
  d150d47

• Merge commit '43989c1ef97f42d773b9e99796eef5a2b8ca7742' into cgroupsv2

  PhilippWendler

  committed
  b0f5eb2

• Merge formatting commit '894f9524' into cgroupsv2 and reformat

  PhilippWendler

  committed
  efc4f19

Commits on Mar 17, 2023

• Merge branch 'main' into cgroupsv2

  PhilippWendler

  committed
  2efefe1

• Remove ZFS from list of filesystems that do not support overlayfs

  Show description for b5e8d62
  PhilippWendler

  committed
  b5e8d62

• Fix method call from c4e447c

  PhilippWendler

  committed
  a302f70

• Remove inconsistent pathlib usage from cgroupsv1 code

  Show description for 921929b
  PhilippWendler

  committed
  921929b

• Fix broken merge of 314b32b intro branch cgroupsv2

  PhilippWendler

  committed
  8a7f613

• Remove pystemd as "build dependency" and make it an optional dependency

  Show description for a869c00
  PhilippWendler

  committed
  a869c00

• remove test adjustment that is now unnecessary

  PhilippWendler

  committed
  7f8f5b4

• Silence pytype error about potentially undefined name

  Show description for 92ad434
  PhilippWendler

  committed
  92ad434

• Merge branch 'main' into cgroupsv2

  Show description for 21a4a35
  PhilippWendler

  committed
  21a4a35

• Merge branch 'main' into cgroupsv2

  PhilippWendler

  committed
  5dd0006

• Remove forgotten code from code move back to oomhandler.py in aa0b905

  PhilippWendler

  committed
  1596a6e

• Refactoring: Move code around

  Show description for 51c23c4
  PhilippWendler

  committed
  51c23c4

• Remove more pathlib usage from cgroupsv1 code

  Show description for 3dcb47c
  PhilippWendler

  committed
  3dcb47c

Commits on Mar 30, 2023

• Rename some methods to keep the code more similar with existing code

  PhilippWendler

  committed
  81bfdbf

• Make comments and abstract methods for Cgroups class more consistent

  PhilippWendler

  committed
  4b4f939

• Move print_decimal to benchexec.util

  Show description for 040fcb6
  PhilippWendler

  committed
  040fcb6

• Fix missing log message of benchexec.check_cgroups in cgroupsv2

  Show description for 8ab8111
  PhilippWendler

  committed
  8ab8111

• Remove redundant Cgroups.initialize() call

  Show description for 39808b6
  PhilippWendler

  committed
  39808b6

• Merge branch 'main' into cgroupsv2

  PhilippWendler

  committed
  30e8417

• Move methods around to put them in better order

  PhilippWendler

  committed
  e77404f

• Simplify kill_all_tasks_in_cgroups

  Show description for f787fae
  PhilippWendler

  committed
  f787fae

Commits on Apr 3, 2023

• Simplify handling of process termination on cgroupsv2

  Show description for cd8dad9
  PhilippWendler

  committed
  cd8dad9

• Fix bug for cgroupsv2: child cgroups were not deleted

  PhilippWendler

  committed
  e324181

• Merge branch 'main' into cgroupsv2

  PhilippWendler

  committed
  255ac51

• Guard against child cgroups with unexpected permissions for cgroupsv2

  Show description for 6cb8faf
  PhilippWendler

  committed
  6cb8faf

• Port and enable test with frozen processes for cgroupsv2

  PhilippWendler

  committed
  ff28210

• Remove some unimportant logging that clutters the output

  PhilippWendler

  committed
  cbf6543

• Implement TODO: improve interface of Cgroups.has_tasks()

  Show description for 06ae55b
  PhilippWendler

  committed
  06ae55b

• Avoid crash in read_memory_limit() if limit is "max"

  Show description for 419cae3
  PhilippWendler

  committed
  419cae3

• Check preexisting memory limit also on cgroupsv2

  PhilippWendler

  committed
  7aec1e2

• Refactoring: refactor out common logic

  PhilippWendler

  committed
  51f39fa

• Always read pressure stall information from cgroupsv2

  Show description for 2271d1c
  PhilippWendler

  committed
  2271d1c

• Refactoring: Implement reading of pressure information only once

  PhilippWendler

  committed
  9f1029c

• Rename and document the pressure values that runexec returns

  PhilippWendler

  committed
  327cd01

• Fix missing units for pressure information in XML results

  PhilippWendler

  committed
  2eb1f91

• Implement reading of memory usage for cgroupsv2

  Show description for d3d1d74
  PhilippWendler

  committed
  d3d1d74

• Slight refactorings for reading cgroup values

  PhilippWendler

  committed
  88c337e

• Fix type error found by pytype

  PhilippWendler

  committed
  1c98bc4

• Fix warning about swapaccount being always shown for cgroupsv2

  PhilippWendler

  committed
  590ac51

Commits on Apr 4, 2023

• Detect OOM kills only in our cgroup, not in child cgroups (for cgroupsv2)

  Show description for ae71489
  PhilippWendler

  committed
  ae71489

Commits on Apr 5, 2023

• Fix OOM handling on cgroupsv2

  Show description for 6938ef8
  PhilippWendler

  committed
  6938ef8

• Improve OOM handling for cgroupsv2

  Show description for f2839b7
  PhilippWendler

  committed
  f2839b7

• fix failure in case key does not exist

  PhilippWendler

  committed
  e428fa2

• fix logic bug

  PhilippWendler

  committed
  29d7cfa

Commits on Jul 12, 2023

• Merge branch 'main' into cgroupsv2

  PhilippWendler

  committed
  cb7403e

• Put our systemd scope into a separate slice

  Show description for a5655f4
  PhilippWendler

  committed
  a5655f4

• Require that we are the only process in our cgroup for cgroupsv2

  Show description for 2f3aa04
  PhilippWendler

  committed
  2f3aa04

Commits on Aug 24, 2023

• Merge branch 'main' into cgroupsv2

  PhilippWendler

  committed
  07c69b9

• Use cgroup namespace for runs with cgroupsv2

  Show description for 14d8210
  PhilippWendler

  committed
  14d8210

• Refactoring: Move code to separate method to allow reuse

  PhilippWendler

  committed
  f63bb3d

• Add another nesting level of cgroups in case of cgroup namespaces

  Show description for a6d7d36
  PhilippWendler

  committed
  a6d7d36

• Add --cgroup-access to containerexec for cgroupsv2

  Show description for f0ad1df
  PhilippWendler

  committed
  f0ad1df

• add some type annotations and checks to help pytype

  PhilippWendler

  committed
  0cc4975

• Better error message for problem of missing cpuset delegation

  Show description for 6cbd9fc
  PhilippWendler

  committed
  6cbd9fc

Commits on Sep 5, 2023

• code style

  PhilippWendler

  committed
  2a0eec2

Commits on Oct 19, 2023

• Update Debian package config for cgroupsv2

  Show description for d17198e
  PhilippWendler

  committed
  d17198e

• Update installation instructions with cgroups v2

  PhilippWendler

  committed
  40d3986

• Handle failure case of r/o cgroupfs for cgroupsv2

  Show description for fa8a85d
  PhilippWendler

  committed
  fa8a85d

• more documentation for cgroups v2

  PhilippWendler

  committed
  93f22e7

• Merge branch 'main' into cgroupsv2

  PhilippWendler

  committed
  2d08b1d

Commits on Oct 20, 2023

• polish documentation for cgroups v2

  Show description for d97af63
  PhilippWendler

  committed
  d97af63

• Let check_cgroups produce better error message for missing CPUSET

  Show description for 3b2a933
  PhilippWendler

  committed
  3b2a933

• Silence warning about missing CPUSET if not required

  Show description for f8348a7
  PhilippWendler

  committed
  f8348a7