forked from anza-xyz/agave
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prio scheduler crate #2
Open
flame4
wants to merge
15
commits into
master
Choose a base branch
from
prio-scheduler-crate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flame4
force-pushed
the
prio-scheduler-crate
branch
from
October 11, 2024 13:03
6cf9bdb
to
064d9a1
Compare
flame4
force-pushed
the
prio-scheduler-crate
branch
from
October 14, 2024 07:07
04e7590
to
32ce898
Compare
flame4
force-pushed
the
prio-scheduler-crate
branch
2 times, most recently
from
October 16, 2024 02:52
739519a
to
b118a73
Compare
flame4
force-pushed
the
prio-scheduler-crate
branch
from
October 16, 2024 02:54
b118a73
to
6ab80ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the definition and implementation of
PrioGraphScheduler
and related components is coupled withbanking-stage
onsolana-core
crate, with most of useful api availabilty apub(crate)
, so it's hard to reuse.Summary of Changes
PrioGraphScheduler
as indepent component to use.SchedulerController
handles a lot of forwarding and decision making logic, which is not related to scheduer itself, so just left insolana_core
.ImmutableDeserializedPacket
. To avoid circular dependencies, just raise up a Trait typeDeserializableTxPacket
and letImmutableDeserializedPacket
impls this trait. It also helps modularity of solana crate.IdGenerator
to replaceTransactionIdGenerator
andBatchIdGenerator
, which is quite same.TARGET_NUM_TRANSACTIONS_PER_BATCH
andReadWriteAccountSet
.