Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label_catalogue configuration node deprecation message #8099

Conversation

7ochem
Copy link
Contributor

@7ochem 7ochem commented Sep 8, 2023

Subject

This PR fixes the faulty (copy-paste mistake) label_catalogue configuration node deprecation message. It confused me, because I searched my project for the use of default_label_catalogue but could not find anything. It seemed I have been using
label_catalogue in my project, which triggered the deprecation message.

Apparently the has been a small copy-paste mistake of

// NEXT_MAJOR: Remove this option.
->scalarNode('default_label_catalogue')
->setDeprecated(
'sonata-project/admin-bundle',
'4.9',
'The "default_label_catalogue" node is deprecated, use "default_translation_domain" instead.'
)
->defaultValue('SonataAdminBundle')
->info('Label Catalogue used for admin services if one isn\'t provided.')

I am targeting the 4.x branch, because it is a patch fix and it is backwards compatible.

Changelog

### Fixed
- `label_catalogue` configuration node deprecation message

@VincentLanglet VincentLanglet merged commit 0bad359 into sonata-project:4.x Sep 8, 2023
23 checks passed
@VincentLanglet
Copy link
Member

Thanks

@7ochem 7ochem deleted the fix-label_catalogue-configuration-node-deprecation branch September 8, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants