Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws][feat] Add collection of GuardDuty resource #2255

Merged
merged 19 commits into from
Nov 1, 2024

Conversation

1101-1
Copy link
Collaborator

@1101-1 1101-1 commented Oct 17, 2024

Description

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@aquamatthias
Copy link
Member

Let's use the new assessment structure to report inspector findings instead of separate resources.

Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the new assessment structure to report inspector findings instead of separate resources.

@1101-1 1101-1 force-pushed the km/aws_guardduty_resource branch from b2fbe5f to 0009442 Compare October 22, 2024 11:57
@1101-1 1101-1 force-pushed the km/aws_guardduty_resource branch from 5d94b54 to 4ad2ffc Compare October 31, 2024 15:21
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aquamatthias aquamatthias merged commit 65c98f7 into main Nov 1, 2024
6 checks passed
@aquamatthias aquamatthias deleted the km/aws_guardduty_resource branch November 1, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants