Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws][fix] Collect and connect Inspector resources properly #2253

Merged
merged 38 commits into from
Oct 30, 2024

Conversation

1101-1
Copy link
Collaborator

@1101-1 1101-1 commented Oct 17, 2024

Description

fix connection issues

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@aquamatthias
Copy link
Member

Let's use the new assessment structure to report inspector findings instead of separate resources.

Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the new assessment structure to report inspector findings instead of separate resources.

plugins/aws/fix_plugin_aws/resource/base.py Outdated Show resolved Hide resolved
fixlib/fixlib/baseresources.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/base.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/base.py Outdated Show resolved Hide resolved
@aquamatthias aquamatthias merged commit ebb67be into main Oct 30, 2024
23 checks passed
@aquamatthias aquamatthias deleted the km/aws_fix_inspector_collection branch October 30, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants