Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resotolib][feat] ModelExport: include name and description #1820

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

aquamatthias
Copy link
Member

Description

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (28a13a6) 89.84% compared to head (c8f95de) 89.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1820   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files          91       91           
  Lines       15686    15721   +35     
=======================================
+ Hits        14093    14125   +32     
- Misses       1593     1596    +3     
Flag Coverage Δ
resotocore 89.84% <91.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
resotocore/resotocore/model/exportable_model.py 82.97% <100.00%> (+4.60%) ⬆️
resotocore/resotocore/model/model.py 93.54% <92.85%> (-0.09%) ⬇️
resotocore/resotocore/web/api.py 72.20% <77.77%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

meln1k
meln1k previously approved these changes Nov 10, 2023
Copy link
Member

@meln1k meln1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise lgtm

@meln1k meln1k merged commit 85f23ec into main Nov 10, 2023
27 checks passed
@meln1k meln1k deleted the mv/model_export branch November 10, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants