[azure] [fix] Fixed collecting network resources + added tests #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1101-1
requested review from
lloesche,
aquamatthias and
meln1k
as code owners
1101-1
force-pushed
the
network_resource_fixes
branch
2 times, most recently
from
e47fae6 to
e511fc7
Compare
1101-1
force-pushed
the
network_resource_fixes
branch
from
e511fc7 to
09815e6
Compare
1101-1
force-pushed
the
network_resource_fixes
branch
from
2d2b802 to
8504f68
Compare
aquamatthias
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Checksum Bug: Resolved an issue related to checksum calculation for resources. The issue was causing duplicate checksums for certain resource types. This problem has been fixed by ensuring that keys used for checksum calculation are distinct and unique for each resource.
Fixed Resource Collection: Refactored and improved the resource collection process. This change enhances the collection of resources, ensuring they are correctly identified and processed.
Added Tests: Included new test cases to validate the correctness of the resource collection.
To-Dos
toxCode of Conduct
By submitting this pull request, I agree to follow the code of conduct.