[azure][fix] Fix model and remove useless resources #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1101-1
reviewed
Oct 25, 2023
| @@ -3238,7 +3242,7 @@ class AzureExpressRoutePort(AzureResource): | |||
| "ether_type": S("properties", "etherType"), | |||
| "identity": S("identity") >> Bend(AzureManagedServiceIdentity.mapping), | |||
| "links": S("properties", "links") >> ForallBend(AzureExpressRouteLink.mapping), | |||
| "mtu_string": S("properties", "mtu"), # TODO: check if this string is actually an int? | |||
| "mtu_string": S("properties", "mtu"), # TODO: check if this string is actually an int? | |||
There was a problem hiding this comment.
As I saw, this property have a string type.
| properties.mtu | string | Maximum transmission unit of the physical port pair(s). |
|---|
And in example json response we can also see a string type of mtu property
"properties": {
...
"mtu": "1500",
...
}There was a problem hiding this comment.
Let us convert this string into a number.
1101-1
reviewed
Oct 25, 2023
| @@ -3487,7 +3491,7 @@ class AzureFirewallPolicy(AzureResource): | |||
| >> Bend(AzureFirewallPolicyIntrusionDetection.mapping), | |||
| "provisioning_state": S("properties", "provisioningState"), | |||
| "rule_collection_groups": S("properties") >> S("ruleCollectionGroups", default=[]) >> ForallBend(S("id")), | |||
| "size_string": S("properties", "size"), # TODO: check if this is actually an int? | |||
| "size_string": S("properties", "size"), # TODO: check if this is actually an int? | |||
There was a problem hiding this comment.
This property also have a string type
| properties.size | string | A read-only string that represents the size of the FirewallPolicyPropertiesFormat in MB. (ex 0.5MB) |
|---|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To-Dos
toxCode of Conduct
By submitting this pull request, I agree to follow the code of conduct.