Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resotocore][feat] --ca-cert is added to the client context #1792

Merged
merged 5 commits into from
Oct 2, 2023

Conversation

aquamatthias
Copy link
Member

Description

A CA certificate passed to --ca-cert is added to the client SSL context.

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (18f7567) 89.85% compared to head (a343850) 89.94%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
+ Coverage   89.85%   89.94%   +0.08%     
==========================================
  Files          91       91              
  Lines       15495    15500       +5     
==========================================
+ Hits        13923    13941      +18     
+ Misses       1572     1559      -13     
Flag Coverage Δ
resotocore 89.94% <82.35%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
resotocore/resotocore/web/certificate_handler.py 92.85% <82.35%> (+8.96%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aquamatthias aquamatthias merged commit f6ac06e into main Oct 2, 2023
28 checks passed
@aquamatthias aquamatthias deleted the mv/client_context branch October 2, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants