Merge branch 'main' into km/add_metrics_collection_to_pubsub_and_buck…

…et_resources
someengineering · Dec 9, 2024 · dd9ad77 · dd9ad77
2 parents 0b61d54 + 68832c0
commit dd9ad77
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/plugins/aws/fix_plugin_aws/resource/inspector.py b/plugins/aws/fix_plugin_aws/resource/inspector.py
@@ -115,8 +115,7 @@ def parse_finding(self, source: Json) -> Finding:
         if self.remediation and self.remediation.recommendation:
             remediation = self.remediation.recommendation.text or ""
         updated_at = self.updated_at
-        details = source.get("packageVulnerabilityDetails", {}) | source.get("codeVulnerabilityDetails", {})
-        return Finding(finding_title, finding_severity, description, remediation, updated_at, details)
+        return Finding(finding_title, finding_severity, description, remediation, updated_at, None)
 
     @classmethod
     def collect_resources(cls, builder: GraphBuilder) -> None:

diff --git a/plugins/gcp/fix_plugin_gcp/resources/scc.py b/plugins/gcp/fix_plugin_gcp/resources/scc.py
@@ -157,15 +157,11 @@ def parse_finding(self, source: Json) -> Optional[Finding]:
             else:
                 remediation = None
                 title = "unknown"
-            source_finding = source.get("finding", {})
             source_resource = source.get("resource", {})
-            details = source_finding.get("sourceProperties", {})
             aws_metadata = source_resource.get("awsMetadata", {})
             azure_metadata = source_resource.get("azureMetadata", {})
             severity = SEVERITY_MAPPING.get(finding.severity or "") or Severity.medium
-            return Finding(
-                title, severity, description, remediation, finding.event_time, details | aws_metadata | azure_metadata
-            )
+            return Finding(title, severity, description, remediation, finding.event_time, aws_metadata | azure_metadata)
         return None
 
     @classmethod