updated tests

plugins/aws/test/collector_test.py

@@ -11,6 +11,7 @@
     called_collect_apis,
     called_mutator_apis,
 )
+from fix_plugin_aws.resource.guardduty import AwsGuardDutyFinding
 from fix_plugin_aws.resource.base import AwsResource, AwsApiSpec, GraphBuilder, AwsRegion
 from fix_plugin_aws.resource.ec2 import AwsEc2Instance
 from fixlib.baseresources import BaseResource
@@ -29,6 +30,9 @@ def count_kind(clazz: Type[AwsResource]) -> int:
         return count
 
     for resource in all_resources:
+        # we do not add findings to the graph --> skip check
+        if issubclass(resource, AwsGuardDutyFinding):
+            continue
         assert count_kind(resource) > 0, f"No instances of {resource.__name__} found"
 
     # make sure all threads have been joined

plugins/aws/test/resources/files/guardduty/get-findings__foo_foo.json

@@ -8,7 +8,7 @@
             "Description": "foo",
             "Id": "foo",
             "Partition": "foo",
-            "Region": "foo",
+            "Region": "global",
             "Resource": {
                 "AccessKeyDetails": {
                     "AccessKeyId": "foo",
@@ -83,7 +83,7 @@
                     },
                     "ImageDescription": "foo",
                     "ImageId": "foo",
-                    "InstanceId": "foo",
+                    "InstanceId": "i-1",
                     "InstanceState": "foo",
                     "InstanceType": "foo",
                     "OutpostArn": "foo",

plugins/aws/test/resources/guardduty_test.py

@@ -0,0 +1,8 @@
+from fix_plugin_aws.resource.ec2 import AwsEc2Instance
+from fix_plugin_aws.resource.guardduty import AwsGuardDutyFinding
+from test.resources import round_trip_for
+
+
+def test_guardduty_findings() -> None:
+    collected, _ = round_trip_for(AwsEc2Instance, region_name="global", collect_also=[AwsGuardDutyFinding])
+    assert len(collected._assessments) == 1