Fix Rubocop violations

solidusio · Feb 5, 2021 · 8fdbea9 · 8fdbea9
1 parent f477bed
commit 8fdbea9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -43,6 +43,10 @@ RSpec/VerifiedDoubles:
   # Sometimes you really need an "anything" double
   IgnoreSymbolicNames: true
 
+Rspec/Naming/VariableNumber:
+  # PayPal uses snake_case, we use normal_case ¯\_(ツ)_/¯
+  Enabled: false
+
 Style/FrozenStringLiteralComment:
   Exclude:
     - spec/**/*

diff --git a/spec/requests/solidus_paypal_commerce_platform/orders_controller_spec.rb b/spec/requests/solidus_paypal_commerce_platform/orders_controller_spec.rb
@@ -15,7 +15,7 @@
 
         get solidus_paypal_commerce_platform.verify_total_path, params: params
 
-        expect(response).to have_http_status(200)
+        expect(response).to have_http_status(:ok)
       end
     end
 
@@ -29,7 +29,7 @@
 
         get solidus_paypal_commerce_platform.verify_total_path, params: params
 
-        expect(response).to have_http_status(400)
+        expect(response).to have_http_status(:bad_request)
       end
     end
   end

diff --git a/spec/requests/solidus_paypal_commerce_platform/wizard_controller_spec.rb b/spec/requests/solidus_paypal_commerce_platform/wizard_controller_spec.rb
@@ -38,7 +38,7 @@
 
       expect(payment_method.preferred_client_id).to eq("CLIENT-ID")
       expect(payment_method.preferred_client_secret).to eq("CLIENT-SECRET")
-      expect(response).to have_http_status(201)
+      expect(response).to have_http_status(:created)
     end
   end
 end