chore: remove vitest globals types from base tsconfig #2237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
tsconfig.json
file includes types forvitest/globals
. Those types are already included intsconfig.test.json
which makes them available in test files. If we include the types intsconfig.json
we make them available in all files.This is, for example, what happens in
packages/solid/src/index.ts
:After this change a TypeScript error is shown instead:
How did you test this change?
I run
pnpm run build && pnpm run test && pnpm run types
.This is my first PR to this project so please let me know if I missed something.