Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .js extension to import that is missing it #1913

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

frank-weindel
Copy link
Contributor

@frank-weindel frank-weindel commented Oct 11, 2023

Summary

Trying to build a Solid renderer using the Node16 moduleResolution of TypeScript and we're seeing this error:

node_modules/solid-js/types/render/hydration.d.ts:1:29 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

1 import { Computation } from "../reactive/signal";
                              ~~~~~~~~~~~~~~~~~~~~

This seems to be the only place in the solid-js package that doesn't add the .js extension to the import path.

How did you test this change?

  • pnpm test
  • Confirm that it fixes issue

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

🦋 Changeset detected

Latest commit: 1489285

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frank-weindel frank-weindel changed the title Add .js extension to import Add .js extension to import that is missing it Oct 11, 2023
@ryansolid
Copy link
Member

Yeah that's an odd omission. Thanks

@frank-weindel
Copy link
Contributor Author

You got the changeset in right before I could 😄

@ryansolid ryansolid merged commit 4968fe2 into solidjs:main Oct 11, 2023
1 check passed
@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 6477684850

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.545%

Totals Coverage Status
Change from base Build 6474147588: 0.0%
Covered Lines: 4143
Relevant Lines: 4360

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants