fix missing disposal of nested transition nodes

solidjs · Sep 3, 2024 · e4b2c66 · e4b2c66
1 parent 30725b2
commit e4b2c66
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/weak-fishes-wait.md b/.changeset/weak-fishes-wait.md
@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+fix missing disposal of nested transition nodes
diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts
@@ -1654,12 +1654,12 @@ function cleanNode(node: Owner) {
     }
   }
 
+  if ((node as Memo<any>).tOwned) {
+    for (i = (node as Memo<any>).tOwned!.length - 1; i >= 0; i--)
+      cleanNode((node as Memo<any>).tOwned![i]);
+    delete (node as Memo<any>).tOwned;
+  }
   if (Transition && Transition.running && (node as Memo<any>).pure) {
-    if ((node as Memo<any>).tOwned) {
-      for (i = (node as Memo<any>).tOwned!.length - 1; i >= 0; i--)
-        cleanNode((node as Memo<any>).tOwned![i]);
-      delete (node as Memo<any>).tOwned;
-    }
     reset(node as Computation<any>, true);
   } else if (node.owned) {
     for (i = node.owned.length - 1; i >= 0; i--) cleanNode(node.owned[i]);