Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-55892: Package workflow #3

Merged
merged 2 commits into from
Jan 3, 2024
Merged

NH-55892: Package workflow #3

merged 2 commits into from
Jan 3, 2024

Conversation

xuan-cao-swi
Copy link

Description

Change exit status based on last statement

@xuan-cao-swi xuan-cao-swi requested a review from a team January 2, 2024 15:36
Copy link

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would steps such as bundle install or gem build fail but still end in a success exit for this script? If so, maybe using set -e is an option.

@xuan-cao-swi
Copy link
Author

Would steps such as bundle install or gem build fail but still end in a success exit for this script? If so, maybe using set -e is an option.

If bundle install or gem build fail it will fail since there is no gem file to send over the github package; but I agree set -e is a good solution. I have changed it to both ruby and ruby-contrib

Copy link

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the revisit @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit d6721e6 into main Jan 3, 2024
45 of 46 checks passed
@xuan-cao-swi xuan-cao-swi deleted the package-workflow branch January 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants