[WIP] AO-14906: remove the old udp reporter #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
Currently, there are a few fields, e.g., the custom metrics, are attached to the gRPC reporter which makes it not just a transport layer as indicated by its name. On the other hand, the UDP reporter is just a thin layer reporting events/metrics via UDP.
In addition, a few global variables exist in the package to do the protocol-independent tasks. For example, the global settings and configurations. These global variables make testing a tough job. What's more, in order to add a new feature we may have to either implement it in each reporter or use another global variable.
For ease of testing, we're trying to eliminate the global variables by attaching the settings and configurations to the reporter and make the (unified) reporter protocol-agnostic. The transport layer (either gRPC or UDP or something else) could be a field of the reporter which only does the final data transportation work.
The first step to achieve the above goal is to remove the old UDP reporter. It will be added back (in a different way) in case it's needed in the future.