Define IDL instructions for the interest bearing mint extension #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let me fix merge conflict in a bit |
|
Done 💯 |
lorisleiva
requested changes
Nov 14, 2024
clients/js/test/extensions/interestBearingMint/updateInterestBearingMint.test.ts
Outdated
Show resolved
Hide resolved
|
Okay sure. I will fix it by tonight (GMT+7). Thanks for the review ❤️ |
|
Thank you! No rush. 👌 |
- change `isSigner` from `true` to `either` in account rateAuthority in updateRateInterestBearingMint - use `createMint` function instead then update instruction in updateInterestBearingMint test
|
Fixed as review. Thanks for the review lorisleiva ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the Interest Bearing Mint extension in IDL with test.
This pull request was created for https://app.gib.work/bounties/cadbce12-707f-4bde-967f-386cd83f5c2d in an attempt to solve a bounty #20 . Payment for the bounty is immediately sent to the contributor after merge.