Define IDL for initialize permanent delegate instruction #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorisleiva
requested changes
Nov 13, 2024
Comment on lines
24
to
29
| const mintAddress = await createMint({ | ||
| authority, | ||
| client, | ||
| extensions: [permanentDelegateExtension], | ||
| payer: authority, | ||
| }); |
There was a problem hiding this comment.
Because here, we're testing the initialisation, would you mind using the longer version instead of the createMint helper?
There was a problem hiding this comment.
Sure will update this.
There was a problem hiding this comment.
@lorisleiva I have updated code with a longer version of mint and rebased it with the main branch. Please review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually updates the Codama IDL to support all instructions in the permanent delegate instruction. This allows helpers to be generated for the new web3.js.
This pull request was created for https://app.gib.work/bounties/c17c023a-e6e0-4e4d-8dce-6e1a432f4c28 in an attempt to solve a bounty #26 . Payment for the bounty is immediately sent to the contributor after merge.