Add withdraw excess with test cases

[DogukanGun]

Add withdraw excess with test cases.
This pull request was created for https://app.gib.work/bounties/12adc3ff-7afb-45cd-99c0-399bc43f4807 in an attempt to solve a bounty #27 . Payment for the bounty is immediately sent to the contributor after merge.

[DogukanGun]

Hi @lorisleiva ,

Thanks for the review, I fixed the parts you mentioned.

[lorisleiva]

Hmm, I believe these changes should not exist if things we properly formatted. Have you tried the script that fixes linting/formatting?

[DogukanGun]

Yes, did lint and formatting same time. I can change this manually, it is up to you.

[lorisleiva]

Oh, looks like the formatting doesn't affect this file. 😞

Yeah if we could make sure this PR doesn't include unnecessary changes, that'd be great!

[lorisleiva]

There are a few things that needs to be adjusted before I can review this in more details. Please have a look at PR #38 for reference of what we're looking for. 🙏

• ❌ Add the instruction in idl.json in the right place (ordered by discriminator).
• ❓ Update getInitializeInstructionsForExtensions.ts accordingly.
• ❌ Add tests that follow the same conventions as the existing tests.
• ✅ Ensure the right discriminator is set.
• ❓ Ensure the multiSigner remaining account is set when applicable.

[DogukanGun]

There are a few things that needs to be adjusted before I can review this in more details. Please have a look at PR #38 for reference of what we're looking for. 🙏

• ❌ Add the instruction in idl.json in the right place (ordered by discriminator).
• ❓ Update getInitializeInstructionsForExtensions.ts accordingly.
• ❌ Add tests that follow the same conventions as the existing tests.
• ✅ Ensure the right discriminator is set.
• ❓ Ensure the multiSigner remaining account is set when applicable.

Hi @lorisleiva , thanks for the update. I updated the idl.json and also change test case according to reference. Haven't done any changes in getInitializeInstructionsForExtensions.ts because this is not a token extension. Also multiSigner remaining account is set, checked it again.

[lorisleiva]

Thank you! Almost there, just a few more comments before merging! 💪

[DogukanGun]

Hi @lorisleiva , thanks for the review. Code is updated according to your review.

[lorisleiva]

Few more changes before merging this in. Then, if the tests are passing, LGTM!

Also please fix formatting to make CI pass. 🙏

[lorisleiva]

The test is failing due to Attempt to debit an account but found no record of a prior credit.. It looks like some other account need SOL, or perhaps the payer is not set properly on a transaction. Could you please investigate? Once this is fixed, we're good to merge though.

[DogukanGun]

The test is failing due to Attempt to debit an account but found no record of a prior credit.. It looks like some other account need SOL, or perhaps the payer is not set properly on a transaction. Could you please investigate? Once this is fixed, we're good to merge though.

Hi @lorisleiva , thanks for the review. Updated the test case.

[lorisleiva]

Perfection! Thank you for your contribution! 🍺