interface: Add WASM build to CI and fix it #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The solana-system-interface crate is meant to work with WASM, but it's not currently tested in CI. #### Summary of changes * Add `crate-type` to Cargo.toml, which is required for wasm-pack * Add step testing `wasm-pack` in CI
|
The JS job was failing because this PR declares the interface crate as a Instead, this PR now checks to see if there's a declared cc @lorisleiva since we literally discussed this earlier today 😅 |
febo
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The solana-system-interface crate is meant to work with WASM, but it's not currently tested in CI.
Summary of changes
crate-typeto Cargo.toml, which is required for wasm-packwasm-packin CI