Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch fd conformance check #25

Merged
merged 1 commit into from
Nov 14, 2024
Merged

patch fd conformance check #25

merged 1 commit into from
Nov 14, 2024

Conversation

buffalojoec
Copy link
Contributor

Adds some additional logic for evaluating whether or not the tests have passed by first seeing if failed_protobufs exists, and then attempting to check its contents.

lorisleiva
lorisleiva approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@buffalojoec buffalojoec merged commit 30eaca3 into main Nov 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorisleiva lorisleiva lorisleiva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @lorisleiva