Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program: reorder lamport deduction on close #46

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

buffalojoec
Copy link
Contributor

Problem

In the tiniest of discrepancies, the Firedancer tooling shed light on the fact that the builtin version of ALT attempts to credit the recipient before attempting to debit the lookup table account.

Summary of Changes

For the utmost, fine-toothed backwards compatibility, flip the ordering to match in the BPF version.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@buffalojoec buffalojoec force-pushed the lamport-deduction-ordering branch from f42a789 to d7f772e Compare November 13, 2024 16:52
@buffalojoec buffalojoec merged commit 654736b into main Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants