Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I don't really like this change, but I'm putting it up here for discussion.
In the SDK,
PubkeyError
can be mapped toProgramError
, but notInstructionError
. That means the builtin will throw custom error codes whenPubkey::create_program_address
fails, but the BPF version will throw a properProgramError
.Summary of Changes
Put some awful indirection into the processor to map
PubkeyError
to custom error codes, just like the builtin.