Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite tests with Mollusk #32

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Rewrite tests with Mollusk #32

merged 3 commits into from
Oct 18, 2024

Conversation

buffalojoec
Copy link
Contributor

This PR rewrites all program tests with Mollusk instead of solana-program-test.

Note: The use of 0.0.3 instead of 0.0.2 is intentional, it includes a fix for slot hashes on warped slots.

Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much code deletion! 🤤

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one substantive comment, looks really good otherwise!

program/tests/close_lookup_table_ix.rs Show resolved Hide resolved
program/tests/close_lookup_table_ix.rs Outdated Show resolved Hide resolved
program/tests/close_lookup_table_ix.rs Outdated Show resolved Hide resolved
program/tests/create_lookup_table_ix.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@buffalojoec buffalojoec merged commit 7746868 into main Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants