update linting configurations

solana-program · Oct 24, 2024 · 41b747d · 41b747d
1 parent c62c2bd
commit 41b747d
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 6 deletions.
diff --git a/program/Cargo.toml b/program/Cargo.toml
@@ -35,3 +35,11 @@ crate-type = ["cdylib", "lib"]
 
 [build-dependencies]
 rustc_version = "0.4"
+
+[lints.rust.unexpected_cfgs]
+level = "warn"
+check-cfg = [
+    'cfg(target_os, values("solana"))',
+    'cfg(feature, values("min_specialization"))',
+    'cfg(RUSTC_WITH_SPECIALIZATION)',
+]
diff --git a/program/tests/create_lookup_table_ix.rs b/program/tests/create_lookup_table_ix.rs
@@ -64,7 +64,7 @@ fn test_create_lookup_table_idempotent() {
         lookup_table_account.lamports(),
         Rent::default().minimum_balance(LOOKUP_TABLE_META_SIZE)
     );
-    let lookup_table = AddressLookupTable::deserialize(&lookup_table_account.data()).unwrap();
+    let lookup_table = AddressLookupTable::deserialize(lookup_table_account.data()).unwrap();
     assert_eq!(lookup_table.meta.deactivation_slot, Slot::MAX);
     assert_eq!(lookup_table.meta.authority, Some(authority));
     assert_eq!(lookup_table.meta.last_extended_slot, 0);

diff --git a/program/tests/deactivate_lookup_table_ix.rs b/program/tests/deactivate_lookup_table_ix.rs
@@ -36,7 +36,7 @@ fn test_deactivate_lookup_table() {
 
     let lookup_table_account = result.get_account(&lookup_table_address).unwrap();
 
-    let lookup_table = AddressLookupTable::deserialize(&lookup_table_account.data()).unwrap();
+    let lookup_table = AddressLookupTable::deserialize(lookup_table_account.data()).unwrap();
     assert_eq!(lookup_table.meta.deactivation_slot, 0);
 
     // Check that only the deactivation slot changed

diff --git a/program/tests/extend_lookup_table_ix.rs b/program/tests/extend_lookup_table_ix.rs
@@ -44,7 +44,7 @@ fn run_test_case(mollusk: &Mollusk, test_case: TestCase) {
             assert!(matches!(result.program_result, ProgramResult::Success));
 
             let table_account = result.get_account(&test_case.lookup_table_address).unwrap();
-            let lookup_table = AddressLookupTable::deserialize(&table_account.data()).unwrap();
+            let lookup_table = AddressLookupTable::deserialize(table_account.data()).unwrap();
             assert_eq!(lookup_table, expected_account.state);
             assert_eq!(table_account.lamports(), expected_account.lamports);
             assert_eq!(table_account.data().len(), expected_account.data_len);

diff --git a/program/tests/freeze_lookup_table_ix.rs b/program/tests/freeze_lookup_table_ix.rs
@@ -35,7 +35,7 @@ fn test_freeze_lookup_table() {
     );
 
     let lookup_table_account = result.get_account(&lookup_table_address).unwrap();
-    let lookup_table = AddressLookupTable::deserialize(&lookup_table_account.data()).unwrap();
+    let lookup_table = AddressLookupTable::deserialize(lookup_table_account.data()).unwrap();
 
     assert_eq!(lookup_table.meta.authority, None);
 

diff --git a/scripts/client/lint-rust.mjs b/scripts/client/lint-rust.mjs
@@ -10,6 +10,7 @@ import {
 // Configure arguments here.
 const lintArgs = [
   '-Zunstable-options',
+  '--all-targets',
   '--',
   '--deny=warnings',
   ...cliArguments(),

diff --git a/scripts/program/lint.mjs b/scripts/program/lint.mjs
@@ -11,8 +11,8 @@ import {
 // Configure arguments here.
 const lintArgs = [
   '-Zunstable-options',
-  '--features',
-  'bpf-entrypoint,test-sbf',
+  '--all-targets',
+  '--all-features',
   '--',
   '--deny=warnings',
   '--deny=clippy::arithmetic_side_effects',