Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport - feature disable_bpf_loader_instructions to v1.17 #35093

Merged

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Feb 5, 2024

Manual backport of one of two features added in #34194.

Feature Gate Issue: #34424

@t-nelson
Copy link
Contributor

t-nelson commented Feb 5, 2024

is there a test that can come over too?

@Lichtso Lichtso force-pushed the bp/disable_bpf_loader_instructions branch from 9e0327a to ac6b9f5 Compare February 6, 2024 00:24
@Lichtso Lichtso force-pushed the bp/disable_bpf_loader_instructions branch 2 times, most recently from 1cd8a30 to dd3aa68 Compare February 6, 2024 01:26
@Lichtso Lichtso force-pushed the bp/disable_bpf_loader_instructions branch from dd3aa68 to c2879c9 Compare February 6, 2024 01:45
@Lichtso Lichtso requested a review from t-nelson February 6, 2024 01:52
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a4621d8) 81.7% compared to head (c2879c9) 81.7%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #35093     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         806      806             
  Lines      218978   218993     +15     
=========================================
- Hits       178924   178921      -3     
- Misses      40054    40072     +18     

@Lichtso Lichtso merged commit fad585e into solana-labs:v1.17 Feb 6, 2024
34 checks passed
@Lichtso Lichtso deleted the bp/disable_bpf_loader_instructions branch February 6, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants