v1.17: Stops pushing legacy snapshot hashes to crds (backport of #33576) #33581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
I really should've had this in master before the v1.17 branch was cut, but I forgot about it... Anyway, this remove legacy snapshot hashes that is only used by v1.14. Since v1.17 will only co-exist with v1.16 and not v1.14, we're all good. Please refer to the original PR, and its linked Issue for more context/background. This comment may also be helpful: #33576 (comment) |
|
(Update: all good) This PR is blocked until #33573 is merged. |
|
@Mergifyio rebase |
(cherry picked from commit c588f25)
✅ Branch has been successfully rebased |
brooksprumo
force-pushed
the
mergify/bp/v1.17/pr-33576
branch
from
cb668e3 to
46832bb
Compare
Codecov Report
@@ Coverage Diff @@
## v1.17 #33581 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 804 804
Lines 217987 217964 -23
=========================================
- Hits 178319 178259 -60
- Misses 39668 39705 +37 |
willhickey
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #33576 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com