Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rule @typescript-eslint/restrict-template-expressions and fix the only error #3691

Conversation

kox
Copy link

@kox kox commented Dec 6, 2024

This PR intends to fix a small part of issue solana-labs/web3.js-issue-conveyer#4

Specifically, it changes the rule @typescript-eslint/restrict-template-expressions, which is currently set to off, to error.

@mergify mergify bot added the community label Dec 6, 2024
@kox kox changed the title Enable rule and fix the only error Enable rule @typescript-eslint/restrict-template-expressions and fix the only error Dec 6, 2024
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice find. getErrorMessage returns a ReactNode ergo isn't safe to interpolate into a string.
nice_catch-1838825837

@steveluscher steveluscher enabled auto-merge (squash) December 6, 2024 18:03
@steveluscher steveluscher force-pushed the enable-typescript-eslint-template-expressions-rule branch from 1189939 to ad0671a Compare December 6, 2024 18:03
Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: ad0671a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steveluscher steveluscher merged commit 2b49e83 into solana-labs:master Dec 6, 2024
2 of 3 checks passed
@kox kox deleted the enable-typescript-eslint-template-expressions-rule branch December 6, 2024 19:53
@kox
Copy link
Author

kox commented Dec 6, 2024

Very nice find. getErrorMessage returns a ReactNode ergo isn't safe to interpolate into a string.

Thanks for merging, that was fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable @typescript-eslint rules one at a time
2 participants