Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: splitting a stake account now requires the splits to pay rent #2215

Conversation

steveluscher
Copy link
Collaborator

@steveluscher steveluscher commented Feb 28, 2024

Summary

When this feature is activated, splitting a rent account will require that the split recipients' accounts are rent-exempt.

In this PR we give an opportunity, through the stake program client API, for callers to opt to fund the destination account.

Test Plan

cd packages/library-legacy/
pnpm test:unit:node
TEST_LIVE=1 pnpm test:unit:node

@steveluscher
Copy link
Collaborator Author

steveluscher commented Feb 28, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@steveluscher steveluscher force-pushed the 02-28-Splitting_a_stake_account_now_requires_the_splits_to_pay_rent branch from 542a178 to fac6cab Compare February 28, 2024 23:42
@steveluscher steveluscher added the automerge Merge this Pull Request automatically once CI passes label Feb 28, 2024
@steveluscher steveluscher changed the title Splitting a stake account now requires the splits to pay rent fix: splitting a stake account now requires the splits to pay rent Feb 28, 2024
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me. Thanks for fixing!

@steveluscher steveluscher merged commit 19341fc into master Feb 29, 2024
10 checks passed
@steveluscher steveluscher deleted the 02-28-Splitting_a_stake_account_now_requires_the_splits_to_pay_rent branch February 29, 2024 22:50
Copy link
Contributor

github-actions bot commented Mar 2, 2024

🎉 This PR is included in version 1.90.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants