Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing comma which makes JSON example as invalid #641

Merged
merged 1 commit into from
Nov 22, 2024
Merged

removing comma which makes JSON example as invalid #641

merged 1 commit into from
Nov 22, 2024

Conversation

kox
Copy link
Contributor

@kox kox commented Nov 21, 2024

Problem

When I was trying the simulate transaction RPC method, I realized that the example had a typo error.

Summary of Changes

I removed the typo error.

Fixes #

@kox kox requested a review from ZYJLiu as a code owner November 21, 2024 12:34
nickfrosty
nickfrosty approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the fix!

@nickfrosty nickfrosty merged commit 8114422 into solana-foundation:main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfrosty nickfrosty nickfrosty approved these changes

@ZYJLiu ZYJLiu Awaiting requested review from ZYJLiu ZYJLiu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kox @nickfrosty