-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add code testing #585
base: main
Are you sure you want to change the base?
Conversation
@@ -11,7 +11,7 @@ are [connecting to a wallet](/content/cookbook/wallets/connect-wallet-react), | |||
you do not need to worry about the keypair. Otherwise a keypair must be | |||
generated for signing transactions. | |||
|
|||
```javascript | |||
```javascript file=/code/content/cookbook/wallets/create-keypair.ts#L1-L3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check the content displays correctly on solana-com. It looks like if you don't include a filename for a snippet, the provided file path gets used.
Also, why is there a file path, but the code block still contains the snippet?
```javascript file=/code/content/cookbook/wallets/create-keypair.ts#L1-L3
import { Keypair } from "@solana/web3.js";
const keypair = Keypair.generate();
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code block has content for crowdin support i guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a PR on solana-com?
Can you provide more context on the changes and instructions for how I can test your changes locally? Please include the commands to run. When I ran
Also the following error if I run
|
I added a testing section in Contibuting.md
let me know if this command doesn't work. |
This PR resolves the issue where code path was shown on the block as name. |
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Problem
This PR introduces testing for snippets imported in markdown using code-import.
Summary of Changes
node:test
Fixes #