Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and improve close-mint course #536

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

wuuer
Copy link
Contributor

@wuuer wuuer commented Sep 27, 2024

Problem

TERMINOLOGY "mint" is not proper in the context "In this lab, we'll create a mint with the close mint extension.".
missing typescript code example for using an account on devnet while calling "initializeKeypair" in the section [2. Run validator node]
missing typescript code example for importing our
new function in the section [3. Create a mint with close authority]
"mintInfo" is redeclared in the typescript.

Summary of Changes

change "mint" to "token mint account".
add a typescript code example for using an account on devnet while calling "initializeKeypair" in the section [2. Run validator node]
add a typescript code example for importing our new function in the section [3. Create a mint with close authority]
change "const mintInfo" to "let mintInfo" because "mintInfo" is used again in the "CLOSE MINT" code part.

Jeff Wood and others added 3 commits September 27, 2024 09:58
add a typescript code example for using an account on devnet while calling "initializeKeypair" in the section [2. Run validator node]
add a typescript code example for importing our new function in the section [3. Create a mint with close authority]
change "const mintInfo" to "let mintInfo" because "mintInfo" is used again in the "CLOSE MINT" code part.
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't mean to include this one in the bounty (as it's new and not outdated) but you did find some bugs so fair is fair.

@mikemaccana mikemaccana merged commit 8048f51 into solana-foundation:main Oct 4, 2024
10 checks passed
adpthegreat pushed a commit to adpthegreat/developer-content that referenced this pull request Oct 23, 2024
* Update the Token Extensions Program link

* sync token-program.md from main

* change "mint" to "token mint account".
add a typescript code example for using an account on devnet while calling "initializeKeypair" in the section [2. Run validator node]
add a typescript code example for importing our new function in the section [3. Create a mint with close authority]
change "const mintInfo" to "let mintInfo" because "mintInfo" is used again in the "CLOSE MINT" code part.

---------

Co-authored-by: Jeff Wood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants