Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update compressed-nfts.md to use umi and bubblegum plugin #510

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

jim4067
Copy link
Contributor

@jim4067 jim4067 commented Sep 25, 2024

Problem

Summary of Changes

update compressed nfts lesson to use umi and mpl-bubblegum package

Fixes #

Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Lots of small changes (and a few TODOs) but you're 90% of the way there and will likely win this one.

Comment on lines +50 to +51
the blockchain’s **ledger state**, only using the account state to store a
“fingerprint”, or **hash**, of the data. This hash allows you to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested in your rationale here. It seems important to note that ledger state is cheaper than account state.

content/courses/state-compression/compressed-nfts.md Outdated Show resolved Hide resolved
content/courses/state-compression/compressed-nfts.md Outdated Show resolved Hide resolved
content/courses/state-compression/compressed-nfts.md Outdated Show resolved Hide resolved
content/courses/state-compression/compressed-nfts.md Outdated Show resolved Hide resolved
content/courses/state-compression/compressed-nfts.md Outdated Show resolved Hide resolved
content/courses/state-compression/compressed-nfts.md Outdated Show resolved Hide resolved
content/courses/state-compression/compressed-nfts.md Outdated Show resolved Hide resolved
@mikemaccana mikemaccana changed the title feat: update course to use umi and bubblegum plugin feat: update compressed-nfts.md to use umi and bubblegum plugin Oct 2, 2024
@mikemaccana mikemaccana merged commit b28529f into solana-foundation:main Oct 3, 2024
1 of 2 checks passed
@jim4067 jim4067 deleted the jimii/cnft-update branch October 3, 2024 07:40
adpthegreat pushed a commit to adpthegreat/developer-content that referenced this pull request Oct 23, 2024
…na-foundation#510)

* feat: update course to use umi and bubblegum plugin

* Update content/courses/state-compression/compressed-nfts.md

Co-authored-by: Mike MacCana <mike.maccana@gmail.com>

* feat: resolve requested changes

* Update content/courses/state-compression/compressed-nfts.md

---------

Co-authored-by: Mike MacCana <mike.maccana@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants