Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens and Nfts - Updated token-program-advanced lesson #488

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ubadineke
Copy link

Problem

Summary of Changes

  • Updated solana's client from web3 to web3.js
  • Added top level async function
  • Added example explorer transaction link for all lab exercises.
  • Separated lab exercises(revoke and burn) into different files.

Fixes #

Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

tokenMintAccount,
user.publicKey,
);
(async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add this, in fact you were instructed to remove it: https://github.com/solana-foundation/developer-content/blob/main/CONTRIBUTING.md#jsts

Also add filesname= to the code snippets. See https://github.com/solana-foundation/developer-content/blob/main/CONTRIBUTING.md#file-names

@ubadineke
Copy link
Author

@mikemaccana I've implemented the changes.
check it out.

@ubadineke
Copy link
Author

ubadineke commented Sep 24, 2024

Hi @mikemaccana
Please check it out and see if there any other changes you want me to be implement?

@mikemaccana
Copy link
Collaborator

@nickfrosty this looks good, can you please merge it?

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants