Native onchain development - Updated hello world lesson #401
Conversation
There was a problem hiding this comment.
Excellent work with a huge amount of attention to detail. Fix the items above and we can get this in. You're the only person competing for this lesson right now so you have a good change to win it.
Also the external repo has been moved to https://github.com/solana-developers/hello-world-client - please update accordingly!
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
| **accounts**, and **instruction_data** included with the instruction | ||
| - Native Solana programs have a single **entry point** to process instructions. | ||
| - A program processes an instruction using the **program_id**, a list of | ||
| **accounts**, and **instruction_data** included with the instruction. |
There was a problem hiding this comment.
Love the attention to detail here. 👍
There was a problem hiding this comment.
Thank you! @mikemaccana
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
|
|
||
| In the example below, the `process_instruction` function will now return a value | ||
| of type `ProgramResult`. We will go over this in the next section. | ||
| of type `ProgramResult`. We’ll go over this in the next section. |
There was a problem hiding this comment.
| of type `ProgramResult`. We’ll go over this in the next section. | |
| of type `ProgramResult`. We'll go over this in the next section. |
There was a problem hiding this comment.
I'm not totally sure there's any benefit to smart quotes. The rest of the code uses regular quotes so I think we should stick to that, or change it everywhere. Feel free to change my mind!
There was a problem hiding this comment.
This was from old content only, I didn't notice. I have changed it to regular quotes across the lesson.
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
…o fix-onchain-hello-world
Co-authored-by: Mike MacCana <[email protected]>
Co-authored-by: Mike MacCana <[email protected]>
…veloper-content into fix-onchain-hello-world
Co-authored-by: Mike MacCana <[email protected]>
Co-authored-by: Mike MacCana <[email protected]>
Thanks! @mikemaccana I have added all suggested changes and resolved comments. Please let me know if there is additional feedback. |
There was a problem hiding this comment.
Another win @0xCipherCoder ! 🏆
Can you please double check I have moved any outstanding unboxed repos to solana-developers and merged all your PRs to them, and then confirm here?
Also feel free to say hi on telegram and twitter, I'm @mikemaccana
|
Thanks! @mikemaccana Sharing all details here - Program Security Signer auth - PRs are merged and part of solana-developers -Starter | Solution Program Security PDA Sharing - PRs are merged and part of solana-developers - Starter | Solution Onchain Anchor CPI - Movie Review Program - Not moved to solana-developers yet - I have 2 PRs raised for them - Anchor PDA solution | Anchor CPI Solution - add-tokens Onchain Intro to Anchor - Already part of solana-developers but PRs not merged yet - Anchor counter increment solution | Anchor counter decrement solution Program Security Closing Account - Already part of solana-developers but PRs not merged yet - Starter | Solution Program Security Bump Seed Canonicalization - Bump Seed Canonicalization Repo - Not moved to solana-developers yet - I have 2 PRs raised for this - Starter | Solution Program Security Arbitrary CPI - Already part of solana-developers but PRs not merged yet - Starter | Solution Program Security Account Data Matching - Already part of solana-developers but PRs not merged yet - Starter | Solution Program Security Owner Check - Owner Check Repo - Not moved to solana-developers yet - I have 2 PRs raised for this - Starter | Solution Program Security Type Cosplay - Type cosplay Repo - Not moved to solana-developers yet but PRs are merged Hello world client- Hello world repo - Already merged and part of solana-developers Program Security Duplicate Mutable Accounts - Repository - Already merged and part of solana-developers Program Security Reinitialization Attack - Already part of solana-developers PRs not merged yet - Starter | Solution Program Optimization Program configuration - Unbox Repo - Not moved to solana-developers yet - I have 3 PRs raised for this - Starter | Solution | Challenge Program Optimization Program Architecture - Unbox Repo - Not moved to solana-developers yet - I have 2 PRs raised for this - Main solution | Challenge solution Native Onchain Development Program Derived Addresses - Not moved to solana-developers yet - I have 4 PRs raised for this - Movie program starter | Movie program solution | Student intro challenge starter | Student intro challenge solution Native Onchain Development Cross Program Invocations - Not moved to solana-developers yet - I have 3 PRs raised for this - Movie program solution add comments as a starter | Movie program solution add tokens | Movie token client Connecting to offchain data - Oracles - Already moved to solana-developers - I have 1 PR raised for this and need help with additional branch setup for a challenge solution - Oracles - Burry Escrow Main Offline transactions -Durable Nonces - Not moved to solana-developers yet - I have 2 PRs raised for this - Starter | Solution Let me know if anything is missed I am also checking. |
Problem
Fixed grammatical mistakes, and updated code and styling as per guidelines.
Summary of Changes
Unboxed frontend PR - Unboxed-Software/solana-hello-world-client#5
Fixes #