-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialialize-instruction-data-frontend more changes (was refactor(): replace deprecated findProgramAddress with findProgramAddressSync) #346
Conversation
…ressSync The signature '(seeds: (Buffer | Uint8Array)[], programId: PublicKey): Promise<[PublicKey, number]>' of 'web3.PublicKey.findProgramAddress' is deprecated. Updated the code to use the recommended 'findProgramAddressSync' method for better compatibility.
Thanks @EmekaManuel ! This is a good start, but there's still a little more you can do here - including use Can you also please use https://github.com/solana-developers/create-solana-dapp (as mentioned in the bounty) to make the frontend app? I saw your comment on Superteam Earn:
Excellent! Likewise, please use https://github.com/solana-developers/create-solana-dapp to make this (your code should just work as-is, we just want to make sure we are using the same code as our own tutorials). After that we should be able to get this PR merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a few more things that need updating here, see the comment above.
…@solana/web3.js instead of importing the entire package. - Replaced .then() with await for better readability and async handling. - Applied linting to maintain code consistency and clarity. - Replaced abbreviations like tx with more descriptive variable names for better code readability. - Enhanced error handling using trycatch.
hello Mike, I have made the necessary changes :
|
… included the application screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move into your other PR.
Just merged into #369. Please note that these PR's focus on two courses which are |
Closing as will review in #369 |
fix: replace deprecated findProgramAddress with findProgramAddressSync
Problem
The method 'web3.PublicKey.findProgramAddress' is deprecated and may lead to compatibility issues.
Summary of Changes
findProgramAddress
method with the recommendedfindProgramAddressSync
method for more reliable and up-to-date usage.