Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onchain-development local-setup updated #343

Merged
merged 9 commits into from
Sep 24, 2024
Merged

onchain-development local-setup updated #343

merged 9 commits into from
Sep 24, 2024

Conversation

SAMAD101
Copy link
Contributor

@SAMAD101 SAMAD101 commented Aug 24, 2024 •
edited
Loading

Summary of Changes

Made the lesson more elaborate and did some reformatting.

  • small tweek on the objectives
  • More concise Lesson summary
  • Better and more elaborate steps in the lab section with relevant links
  • Added steps and more relevant details to existing steps in the lab section
  • Updated in accordance to latest Solana and Anchor version.
  • Overall improved the quality of the setup guide
  • Added some more common errors and improved details on the existing once; along with their fix

@SAMAD101 SAMAD101 requested a review from nickfrosty as a code owner August 24, 2024 12:55
@SAMAD101 SAMAD101 changed the title onchain local-setup updated onchain-development local-setup updated Aug 24, 2024
mikemaccana
mikemaccana suggested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small work but we can get this in really soon.

@SAMAD101 SAMAD101 requested a review from mikemaccana August 27, 2024 10:07
mikemaccana
mikemaccana suggested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more fixes needed here.

content/courses/onchain-development/local-setup.md Outdated Show resolved Hide resolved
content/courses/onchain-development/local-setup.md Outdated Show resolved Hide resolved
content/courses/onchain-development/local-setup.md Show resolved Hide resolved
content/courses/onchain-development/local-setup.md Show resolved Hide resolved
content/courses/onchain-development/local-setup.md Outdated Show resolved Hide resolved
mikemaccana
mikemaccana suggested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor changes. Just a heads up: someone else already submitted an entry for this which was merged so the chances of winning for this lesson have been reduced but we'd love to get these changes in regardless.

content/courses/onchain-development/local-setup.md Outdated Show resolved Hide resolved
content/courses/onchain-development/local-setup.md Outdated Show resolved Hide resolved
content/courses/onchain-development/local-setup.md Outdated Show resolved Hide resolved
content/courses/onchain-development/local-setup.md Outdated Show resolved Hide resolved
content/courses/onchain-development/local-setup.md Outdated Show resolved Hide resolved
@SAMAD101 SAMAD101 requested a review from mikemaccana September 5, 2024 12:56
mikemaccana
mikemaccana suggested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to get the error for the libssl bits. But yes this is ready to go.

mikemaccana
mikemaccana suggested changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

mikemaccana
mikemaccana approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although you didn't win this once I do appreciate your work very much @SAMAD101! 🙏

@mikemaccana mikemaccana merged commit bf58aac into solana-foundation:main Sep 24, 2024
2 checks passed
@SAMAD101 SAMAD101 deleted the aoc-ls branch September 24, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jereldlimjy jereldlimjy jereldlimjy left review comments

@mikemaccana mikemaccana mikemaccana approved these changes

@nickfrosty nickfrosty Awaiting requested review from nickfrosty

Assignees
No one assigned
Labels
superteam-lesson-updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SAMAD101 @mikemaccana @jereldlimjy