Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update tokens-and-nfts/nfts-with-metaplex to use mpl-token-metadata #339

Merged
merged 5 commits into from
Sep 4, 2024
Merged

feat: update tokens-and-nfts/nfts-with-metaplex to use mpl-token-metadata #339

merged 5 commits into from
Sep 4, 2024

Conversation

jim4067
Copy link
Contributor

@jim4067 jim4067 commented Aug 23, 2024

Problem

remove use of depracated metaplex-foundation/js package

Summary of Changes

Use UMI + mplTokenMetadata for the Metaplex tutorial

@jim4067 jim4067 requested a review from nickfrosty as a code owner August 23, 2024 17:53
@mikemaccana mikemaccana changed the title feat: update tutorial to use umi feat: update tutorial to use mpl-token-metadata Aug 26, 2024
mikemaccana
mikemaccana suggested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent first draft. A few very minor changes but this will be ready to go shortly. looking forward to getting this in and seeing more of your work @jim4067 🚀

content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Show resolved Hide resolved
@mikemaccana mikemaccana changed the title feat: update tutorial to use mpl-token-metadata feat: update tokens-and-nfts/nfts-with-metaplex to use mpl-token-metadata Aug 26, 2024
mikemaccana
mikemaccana suggested changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have shortlisted this in Superteam. Just add images and fix the remaining bits above. After this I'd love you to work on more of these, feel free to grab me on Twitter DM anytime.

content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated Show resolved Hide resolved
content/courses/tokens-and-nfts/nfts-with-metaplex.md Outdated Show resolved Hide resolved
public/assets/courses/unboxed/solana-explorer-with-updated-NFT.png Outdated Show resolved Hide resolved
@jim4067
feat: add images,
c53d140 
move verify nft into own section
@mikemaccana mikemaccana merged commit f723c6b into solana-foundation:main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemaccana mikemaccana mikemaccana approved these changes

@nickfrosty nickfrosty Awaiting requested review from nickfrosty

Assignees
No one assigned
Labels
superteam-lesson-updates superteam-winner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jim4067 @mikemaccana