Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link in hello-world-in-your-browser.md #33

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

MacroChip
Copy link
Contributor

No description provided.

@MacroChip MacroChip requested a review from nickfrosty as a code owner December 7, 2023 22:15
Copy link
Collaborator

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on this! But a better way is the absolute path within this repo. It will allow people to navigate to the file while exploring this repo, and on the respective page on solana.com/developers/guides/*

While you already have this PR open, can you fix the other ./* links within this file?

content/guides/getstarted/hello-world-in-your-browser.md Outdated Show resolved Hide resolved
@MacroChip MacroChip requested a review from nickfrosty December 9, 2023 20:28
@MacroChip
Copy link
Contributor Author

MacroChip commented Dec 9, 2023

I think that's it. Fyi I couldn't get next to compile the app properly to fully verify but I believe it's correct. The links were working properly in vscode.

@nickfrosty
Copy link
Collaborator

I think that's it. Fyi I couldn't get next to compile the app properly to fully verify but I believe it's correct. The links were working properly in vscode.

what was the error you were getting when you tried to build it?
or are you referring to the GitHub action for vercel not completing?

@nickfrosty nickfrosty merged commit 643c7ca into solana-foundation:main Dec 15, 2023
3 of 4 checks passed
@nickfrosty
Copy link
Collaborator

Thanks for the updates here! There was recently a huge docs migration merge into main, so I fixed the links for those changes

@MacroChip
Copy link
Contributor Author

Very sorry I missed this notification. Build is working fine for me now! I don't remember what was happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants