Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor. This should make it easier to maintain. #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blagarde
Copy link

@blagarde blagarde commented Feb 2, 2014

Hi @soimort,
In this branch I have moved all kana-to-romaji mappings outside of the code while making sure to preserve the exact behavior of the existing API. I didn't make any attempt here at fixing the issues I recently opened - this is just laying the ground work for future improvements.

Notes:

  1. I introduced a compat.py module for P2/P3 compatibility code
  2. The only function I've had to rewrite from scratch is to_hepburn. The approach hasn't changed fundamentally though, and all tests continue to pass.

Here is the Travis report: https://travis-ci.org/blagarde/python-romkan/builds/18067424
I look forward to your views/comments.

All the best,
Baptiste

Review on Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant