Major refactor. This should make it easier to maintain. #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @soimort,
In this branch I have moved all kana-to-romaji mappings outside of the code while making sure to preserve the exact behavior of the existing API. I didn't make any attempt here at fixing the issues I recently opened - this is just laying the ground work for future improvements.
Notes:
to_hepburn
. The approach hasn't changed fundamentally though, and all tests continue to pass.Here is the Travis report: https://travis-ci.org/blagarde/python-romkan/builds/18067424
I look forward to your views/comments.
All the best,
Baptiste