Adapt DPsim to deploy it in Mybinder #323
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 2, 2024 14:35
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
…version Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
…version Signed-off-by: Lennart Schumacher <[email protected]>
…y-2 and 3-by-3 matrices by hand Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
…nd replaced pruning by makeCompressed Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
… not every matrix is converted yet Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
Signed-off-by: Lennart Schumacher <[email protected]>
…cal stability Signed-off-by: Lennart Schumacher <[email protected]>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Georgii Tishenin <[email protected]>
Signed-off-by: Georgii Tishenin <[email protected]>
…lver Signed-off-by: Georgii Tishenin <[email protected]>
Signed-off-by: Georgii Tishenin <[email protected]>
Signed-off-by: Georgii Tishenin <[email protected]>
Signed-off-by: Georgii Tishenin <[email protected]>
Signed-off-by: Georgii Tishenin <[email protected]>
- added Ph1::Switch header and cpp files - added header to Components.h - added cpp to CMakeLists.txt - made Ph1::Switch usable in pybind by adding it in EMTComponents.cpp - added simple example circuit (VS_sw_R_L) for new EMT::Ph1::Switch model Signed-off-by: Marvin Tollnitsch <[email protected]>
- declare methods as "override" implementations - encapsulate system matrix stamps using "MNAStampUtils::stampConductance()" Signed-off-by: Marvin Tollnitsch <[email protected]>
reformatted files: - EMT_Ph1_Switch.h - EMT_Ph1_Switch.cpp Signed-off-by: Marvin Tollnitsch <[email protected]>
Signed-off-by: Ghassen Nakti <[email protected]>
Signed-off-by: Ghassen Nakti <[email protected]>
- increase simulation time to 2 seconds - add another switch event to close switch at 1.5 seconds - fix vs parameters by removing frequency for dp and sp domains - add assertions to check Ph1::EMT against Ph3::EMT, Ph1::EMT against dp and dp against sp Signed-off-by: Marvin Tollnitsch <[email protected]>
In our workflow, docker-compose was used corresponding to v1. In the current ubuntu:latest the support for v1 has been deprecated. This commit upgrades the action to v2. Signed-off-by: Leonardo Carreras <[email protected]>
Signed-off-by: Leonardo Carreras <[email protected]>
Signed-off-by: Leonardo Carreras <[email protected]>
…s examples Signed-off-by: Leonardo Carreras <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
pipeacosta
requested review from
m-mirz,
stv0g,
dinkelbachjan,
n-eiling,
gnakti and
leonardocarreras
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a past PR from @stv0g . I made some changes recently and was able to deploy DPsim successfully in Mybinder. This requires to place a new Dockerfile (adapted from the Fedora-based Dockerfile) in the dpsim's root folder. Because this is intended to offer another way of end users to interact with DPsim, I think one important question here is: Should we keep this functionality as part of DPsim's main repo, or should we implement it in a separate repo?