Added begin timestamp to reader #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pask423
commented
Jun 10, 2024
| deserializedMessage.content(), | ||
| message.metaData().timestamp().toLocalDateTime()); | ||
| messageStore.add(msg); | ||
| LocalDateTime messageTimestamp = message |
There was a problem hiding this comment.
Can this ever be null ?
Pask423
commented
Jun 10, 2024
| DeserializedMessage deserializedMessage = | ||
| messageDeserializer.deserializeMessage(ByteBuffer.wrap(message.getData())); | ||
| ReadMessage msg = | ||
| new ReadMessage( |
There was a problem hiding this comment.
how about adding SID here for it to be displayed on frontend ?
Pask423
commented
Jun 10, 2024
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private void deserializeMessage(MessageDeserializer messageDeserializer, Message message, LocalDateTime timestamp) { |
There was a problem hiding this comment.
how about using MessageDeserializer filed from object directly instead of passing it as param ?
added 17 commits
June 18, 2024 11:45
Add dependencies versions Added limit of messages Fix filters factory Use const insted of var and function Added begin timestamp to reader Fix tests setup Fix review issues Added Google Code Style
SebastianRabiej
force-pushed
the
begin-timestamp
branch
from
3581c5b
to
ffc4dcb
Compare
|
I closed that PR because here we read all messages but filter by date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.