fix(iOS): restore behaviour of RNSScreenStackAnimationNone

[kkafar]

Description

There is still some header animation noticeable for some reason. <-- This is because we use fade transition with duration 0 and do not override interruptible animator! To prevent the animation we could either return nil interruptible animator (but overriding the method comes with it's own set of problems, see #2563 and other related) or handle the none animation much earlier, when calling showViewControllers:animated: in updateContainer (pass animated: NO).

PS: If we would want to pass animated: NO I wonder what would happen to dismiss prevention - we implemented it at the stage of the animation start... We need to think this through.

Note: Must be implemented with old animation API, because UIViewPropertyAnimator does not allow for 0 duration (it uses default if the specified animation duration is below some undocumented treshold).

This regression was introduced with #2477

Changes

We now use old API for animation: none & still rely on fade animation to implement it. Note the points made above ☝🏻 - we should refactor this code to make advantage of animated: parameter of the showViewControllers:animated:.

Test code and steps to reproduce

TestAnimation - set stack presentation to none - it works as prior to v4.

WIP VIDEO

Checklist

• Included code example that can be used to test this change
• Updated TS types
• Updated documentation:
  • https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
  • https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
  • https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
  • https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
• Ensured that CI passes

[matinzd]

Is this a fix for #2536?

[hirbod]

@matinzd no, this is for supporting animation: none again, which is broken since v4, as it always fades.
Try to install react-native-screens 4.4.0-rc.0 to see if #2536 is fixed.

[hirbod]

Can we get the fixed none behavior shipped with another rc? Or do I have to patch?

[kkafar]

I'll release it today's evening

[kkafar]

I'm tracking now the "header animation", when the animation: none is set, but it seems that this behaviour was also present before v4 & must be fixed separately.

animation-none-bc-hr.mov

[hirbod]

Yeah, that is great. Thanks for fixing the header mess, was always very unfortunate