Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix misleading contributing guide #2564

Merged
merged 1 commit into from
Dec 10, 2024
Merged

chore: fix misleading contributing guide #2564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions guides/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ To begin with, let install all dependencies:

1. `yarn`
2. `yarn submodules`
3. `(cd react-navigation && yarn prepare)`
4. `cd Example`
4. `cd Example` or `cd FabricExample` (depending on architecture you want to work on)
5. `yarn`
6. `yarn start` – make sure to start metro bundler before building the app in Android Studio

Expand All @@ -108,10 +107,9 @@ To begin with, let install all dependencies:

1. `yarn`
2. `yarn submodules`
3. `(cd react-navigation && yarn prepare)`
4. `cd Example`
4. `cd Example` or `cd FabricExample`
5. `yarn`
6. `(cd ios && pod install)`
6. `(cd ios && pod install && cd ../)`
7. `yarn start` – make sure to start metro bundler before building the app in XCode.

and open `react-native-screens/Example/ios/ScreensExample.xcworkspace` with XCode.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "4.4.0-rc.0",
"description": "Native navigation primitives for your React Native app.",
"scripts": {
"submodules": "git submodule update --init --recursive && (cd react-navigation && yarn)",
"submodules": "git submodule update --init --recursive && (cd react-navigation && yarn && yarn build && cd ../)",
"check-types": "tsc --noEmit",
"start": "react-native start",
"test:unit": "jest --passWithNoTests",
Expand Down
Loading