Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS)!: change default of fullScreenSwipeShadowEnabled to true #2481

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Nov 6, 2024

Description

This PR changes default value for fullScreenSwipeShadowEnabled prop to true - meaning that the shadow will be present by default
in simple_push animation on iOS (this is the platform default).

Important

When changing this value I've noticed that the fullScreenSwipeShadowEnabled does something different
than it suggests in type documentation & our GUIDE_FOR_LIBRARY_AUTHORS. Namely, it does effect simple_push animation
in every scenario, not only in full screen swipe gesture interactive transition. I think we should change the name
of the prop eventually.

Changes

Updated all the docs & code.

Test code and steps to reproduce

I've played around with Test1072. Just set stack animation to simple push.

Checklist

@kkafar kkafar requested a review from alduzy November 6, 2024 08:01
Copy link
Member

@alduzy alduzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but your note is concerning.
We could indeed distinguish the prop name from fullScreenSwipe since it's not that closely related. Even shadowEnabled with current description would be less confusing in my opinion. It may be a good time for such change

@kkafar kkafar merged commit 46c843e into main Nov 6, 2024
9 checks passed
@kkafar kkafar deleted the @kkafar/change-default-value-for-shadow branch November 6, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants