feat(iOS)!: change default of fullScreenSwipeShadowEnabled
to true
#2481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes default value for
fullScreenSwipeShadowEnabled
prop totrue
- meaning that the shadow will be present by defaultin
simple_push
animation on iOS (this is the platform default).Important
When changing this value I've noticed that the
fullScreenSwipeShadowEnabled
does something differentthan it suggests in type documentation & our GUIDE_FOR_LIBRARY_AUTHORS. Namely, it does effect
simple_push
animationin every scenario, not only in full screen swipe gesture interactive transition. I think we should change the name
of the prop eventually.
Changes
Updated all the docs & code.
Test code and steps to reproduce
I've played around with
Test1072
. Just set stack animation to simple push.Checklist