Create example for Windows #2312
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianryt
force-pushed
the
create-windows-example-app
branch
from
f1f3cc0 to
53648e7
Compare
adrianryt
force-pushed
the
create-windows-example-app
branch
from
53648e7 to
6e4f0c9
Compare
adrianryt
commented
Aug 22, 2024
| </PropertyGroup> | ||
| <Import Project="$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.WindowsSdk.Default.props" Condition="Exists('$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.WindowsSdk.Default.props')" /> | ||
| <PropertyGroup Label="Fallback Windows SDK Versions"> | ||
| <WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion> | ||
| <WindowsTargetPlatformMinVersion Condition=" '$(WindowsTargetPlatformMinVersion)' == '' ">10.0.16299.0</WindowsTargetPlatformMinVersion> | ||
| <WindowsTargetPlatformMinVersion Condition=" '$(WindowsTargetPlatformMinVersion)' == '' ">10.0.17763.0</WindowsTargetPlatformMinVersion> |
There was a problem hiding this comment.
Acording to https://github.com/microsoft/microsoft-ui-xaml For WinUI, your app's users must be on Windows 10 1809 - Build 17763 or newer.
adrianryt
commented
Aug 22, 2024
| @@ -15,12 +15,12 @@ | |||
| <ApplicationTypeRevision>10.0</ApplicationTypeRevision> | |||
| </PropertyGroup> | |||
| <PropertyGroup Label="ReactNativeWindowsProps"> | |||
| <ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir> | |||
| <ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir> | |||
There was a problem hiding this comment.
Solution from react-native-windows repo: microsoft/react-native-windows#5911 (comment)
the general fix for having an example app with its own pacakage.json/node_modules in the same repo as their module, and therefore ending up with two copies of react-native-windows - is to update the ReactNativeWindowsDir property in the module's project
adrianryt
force-pushed
the
create-windows-example-app
branch
from
2399ce4 to
64a9e79
Compare
adrianryt
force-pushed
the
create-windows-example-app
branch
from
326d456 to
ec5e88a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Test code and steps to reproduce
Checklist