fix(Android): incorrect childCount in removeViewAt when using flatlist on fabric #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
approved these changes
Aug 20, 2024
|
Hello @kkafar, are you going to create a release soon with this fix? Thanks |
|
Planning a stable 3.35.0 in the beginning of the next week. But don't hold me to it, it will be ready when it will be ready (Cyberpunk vibes unintended) |
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…t on fabric (software-mansion#2307) ## Description This PR intents to fix the crash when navigating back from a screen with FlatList on the new architecture. The crash was caused by miscalculated `childCount` of the list. Earlier on I found out that setting the [removeClippedSubviews](https://reactnative.dev/docs/flatlist#removeclippedsubviews) option to false (defaults to true on Android) in the FlatList fixes the problem. This PR is rather a quick fix with an extra condition, that adds simple views in place of the miscalculated ones in `startTransitionRecursive` function if there's a FlatList with `removeClippedSubviews` option set. Fixes software-mansion#2282. ## Changes - added `Test2282.tsx` repro - added extra condition in `startTransitionRecursive` function <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce - added `Test2282.tsx` repro ## Checklist - [x] Ensured that CI passes
kkafar
pushed a commit
that referenced
this pull request
Oct 25, 2024
…t on fabric (#2307) This PR intents to fix the crash when navigating back from a screen with FlatList on the new architecture. The crash was caused by miscalculated `childCount` of the list. Earlier on I found out that setting the [removeClippedSubviews](https://reactnative.dev/docs/flatlist#removeclippedsubviews) option to false (defaults to true on Android) in the FlatList fixes the problem. This PR is rather a quick fix with an extra condition, that adds simple views in place of the miscalculated ones in `startTransitionRecursive` function if there's a FlatList with `removeClippedSubviews` option set. Fixes #2282. - added `Test2282.tsx` repro - added extra condition in `startTransitionRecursive` function <!-- Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. --> - added `Test2282.tsx` repro - [x] Ensured that CI passes (cherry picked from commit c47ad84)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to fix the crash when navigating back from a screen with FlatList on the new architecture. The crash was caused by miscalculated
childCountof the list.Earlier on I found out that setting the removeClippedSubviews option to false (defaults to true on Android) in the FlatList fixes the problem.
This PR is rather a quick fix with an extra condition, that adds simple views in place of the miscalculated ones in
startTransitionRecursivefunction if there's a FlatList withremoveClippedSubviewsoption set.Fixes #2282.
Changes
Test2282.tsxreprostartTransitionRecursivefunctionTest code and steps to reproduce
Test2282.tsxreproChecklist