fix(iOS): add canCoalesce method to RNSHeaderHeightChangeEvent
#1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also please link the issue in the PR description. Use "Closes/Fixes/..." syntax. |
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…tware-mansion#1933) ## Description It looks like when I was implementing class that is representing the `onHeaderHeightChange` I made a mistake and I forgot / accidentally removed `canCoalesce` method which led to displaying `RNSHeaderHeightChangeEvent: unrecognized selector sent to instance` for a couple of users. This issue resolves that error by adding `canCoalesce` method to the event. Fixes software-mansion#1932. ## Changes - Added `canCoalesce` method to `RNSHeaderHeightChangeEvent` file ## Test code and steps to reproduce You can test the changes by checking `Test1802.tsx` component in FabricTestExample. ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like when I was implementing class that is representing the
onHeaderHeightChangeI made a mistake and I forgot / accidentally removedcanCoalescemethod which led to displayingRNSHeaderHeightChangeEvent: unrecognized selector sent to instancefor a couple of users.This issue resolves that error by adding
canCoalescemethod to the event.Fixes #1932.
Changes
canCoalescemethod toRNSHeaderHeightChangeEventfileTest code and steps to reproduce
You can test the changes by checking
Test1802.tsxcomponent in FabricTestExample.Checklist