Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the glitching of UI when using all detents #1767

Closed
wants to merge 1 commit into from

Conversation

okdltd
Copy link

@okdltd okdltd commented May 3, 2023

Description

Fixes the glitching of UI when using all indents

Fixes #1722

Changes

The change remove the update bounds on iOS. It seems that the bounds effect the height of the content within the modal then causing the glitching seen.

Screenshots / GIFs

Here you can see behaviour of the bottom of the modal

Before

before.MP4

After

after.MP4

Test code and steps to reproduce

To test this in the Example app, go to StackPresentation.tsx, and change this example:

    <Stack.Screen
      name="FormSheet"
      component={FormScreen}
      options={{ stackPresentation: 'formSheet', sheetAllowedDetents: 'all' }}
    />

Checklist

@okdltd okdltd changed the title Fixes the glitching of UI when using all indents Fixes the glitching of UI when using all detents May 3, 2023
@ferrannp
Copy link
Contributor

ferrannp commented May 3, 2023

Awesome 🙌 . cc @kkafar.

@Braden1996
Copy link

What's the status of this? We're running into a similar issue with our app and keen for a fix :)

@kkafar kkafar self-assigned this Jul 4, 2023
@kkafar
Copy link
Member

kkafar commented Jul 20, 2023

Hey, it is likely that this fixes the issue you reported, however the removed code was not there without a reason ;D I can not merge this PR in current state. Different solution must be found.

@kkafar
Copy link
Member

kkafar commented Nov 15, 2023

I've just merged #1870, closing this as outdated. Thanks for contribution!

@kkafar kkafar closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants